feat: rename manager cross-region permission

This commit is contained in:
zhx 2026-07-11 20:36:42 +08:00
parent 8ef5b0c08d
commit f597cb6110
9 changed files with 116 additions and 41 deletions

View File

@ -8875,9 +8875,13 @@
},
"ApiPageManager": {
"type": "object",
"required": ["items", "page", "pageSize", "total", "bdLeaderInviteScopePolicy"],
"required": ["items", "page", "pageSize", "total", "managerOperationScopePolicy"],
"properties": {
"bdLeaderInviteScopePolicy": {
"$ref": "#/components/schemas/ManagerRoleScopePolicy",
"deprecated": true
},
"managerOperationScopePolicy": {
"$ref": "#/components/schemas/ManagerRoleScopePolicy"
},
"items": {
@ -10117,12 +10121,16 @@
},
"ManagerRoleScopePolicy": {
"type": "object",
"required": ["baseScope", "regionExpansionConfigurable"],
"required": ["baseScope", "expandedScope", "regionExpansionConfigurable"],
"properties": {
"baseScope": {
"type": "string",
"enum": ["country", "region", "global"]
},
"expandedScope": {
"type": "string",
"enum": ["country", "region", "global"]
},
"regionExpansionConfigurable": {
"type": "boolean"
}
@ -10145,17 +10153,35 @@
"type": "boolean"
},
"canAddBdLeaderInRegion": {
"type": "boolean",
"deprecated": true
},
"canManageCrossRegion": {
"type": "boolean"
},
"bdLeaderInviteBaseScope": {
"type": "string",
"enum": ["country", "region", "global"]
"enum": ["country", "region", "global"],
"deprecated": true
},
"bdLeaderInviteEffectiveScope": {
"type": "string",
"enum": ["country", "region", "global"]
"enum": ["country", "region", "global"],
"deprecated": true
},
"bdLeaderRegionExpansionConfigurable": {
"type": "boolean",
"deprecated": true
},
"managerOperationBaseScope": {
"type": "string",
"enum": ["country", "region", "global"]
},
"managerOperationEffectiveScope": {
"type": "string",
"enum": ["country", "region", "global"]
},
"managerCrossRegionConfigurable": {
"type": "boolean"
},
"canAddSuperadmin": {
@ -10669,6 +10695,10 @@
"type": "boolean"
},
"canAddBdLeaderInRegion": {
"type": "boolean",
"deprecated": true
},
"canManageCrossRegion": {
"type": "boolean"
},
"canAddSuperadmin": {
@ -10714,6 +10744,10 @@
"type": "boolean"
},
"canAddBdLeaderInRegion": {
"type": "boolean",
"deprecated": true
},
"canManageCrossRegion": {
"type": "boolean"
},
"canAddSuperadmin": {

View File

@ -69,7 +69,7 @@ test("host org list APIs use generated admin paths and filters", async () => {
status: "active",
});
await createManager({
canAddBdLeaderInRegion: false,
canManageCrossRegion: false,
canBlockUser: false,
canGrantBadge: false,
canGrantVip: true,
@ -77,7 +77,7 @@ test("host org list APIs use generated admin paths and filters", async () => {
targetUserId: "1003",
});
await updateManager("1003", {
canAddBdLeaderInRegion: true,
canManageCrossRegion: true,
canBlockUser: false,
canGrantVehicle: true,
canGrantVip: false,
@ -160,7 +160,7 @@ test("host org list APIs use generated admin paths and filters", async () => {
expect(String(managerCreateUrl)).toContain("/api/v1/admin/managers");
expect(managerCreateInit?.method).toBe("POST");
expect(JSON.parse(String(managerCreateInit?.body))).toEqual({
canAddBdLeaderInRegion: false,
canManageCrossRegion: false,
canBlockUser: false,
canGrantBadge: false,
canGrantVip: true,
@ -170,7 +170,7 @@ test("host org list APIs use generated admin paths and filters", async () => {
expect(String(managerUpdateUrl)).toContain("/api/v1/admin/managers/1003");
expect(managerUpdateInit?.method).toBe("PUT");
expect(JSON.parse(String(managerUpdateInit?.body))).toEqual({
canAddBdLeaderInRegion: true,
canManageCrossRegion: true,
canBlockUser: false,
canGrantVehicle: true,
canGrantVip: false,

View File

@ -17,25 +17,28 @@ export const managerPermissionFields = [
"canGrantVip",
"canUpdateUserLevel",
"canAddBdLeader",
"canAddBdLeaderInRegion",
"canManageCrossRegion",
"canAddAdmin",
"canAddSuperadmin",
"canBlockUser",
"canTransferUserCountry",
];
const managerPermissionDefault = (field) => field !== "canAddBdLeaderInRegion";
const managerPermissionDefault = (field) => field !== "canManageCrossRegion";
const managerPermissionEnabled = (source, field) => {
const value = source?.[field];
const value =
field === "canManageCrossRegion"
? (source?.canManageCrossRegion ?? source?.canAddBdLeaderInRegion)
: source?.[field];
return value === undefined || value === null ? managerPermissionDefault(field) : value !== false;
};
const emptyPermissions = () =>
Object.fromEntries(managerPermissionFields.map((field) => [field, managerPermissionDefault(field)]));
const emptyManagerForm = (regionExpansionConfigurable = false) => ({
bdLeaderRegionExpansionConfigurable: regionExpansionConfigurable,
const emptyManagerForm = (crossRegionConfigurable = false) => ({
managerCrossRegionConfigurable: crossRegionConfigurable,
contact: "",
targetUserId: "",
...emptyPermissions(),
@ -51,7 +54,8 @@ const managerStatusPayload = (item, status) => ({
});
const managerFormFromItem = (item) => ({
bdLeaderRegionExpansionConfigurable: item?.bdLeaderRegionExpansionConfigurable === true,
managerCrossRegionConfigurable:
item?.managerCrossRegionConfigurable === true || item?.bdLeaderRegionExpansionConfigurable === true,
contact: item?.contact || "",
targetUserId: String(item?.userId || ""),
...Object.fromEntries(managerPermissionFields.map((field) => [field, managerPermissionEnabled(item, field)])),
@ -133,7 +137,7 @@ export function useHostManagersPage() {
});
showToast("经理已添加", "success");
}
setManagerForm(emptyManagerForm(data.bdLeaderInviteScopePolicy?.regionExpansionConfigurable === true));
setManagerForm(emptyManagerForm(managerCrossRegionConfigurable(data)));
setActiveAction("");
setEditingManager(null);
await reload();
@ -147,12 +151,12 @@ export function useHostManagersPage() {
const closeAction = () => {
setActiveAction("");
setEditingManager(null);
setManagerForm(emptyManagerForm(data.bdLeaderInviteScopePolicy?.regionExpansionConfigurable === true));
setManagerForm(emptyManagerForm(managerCrossRegionConfigurable(data)));
};
const openManagerForm = () => {
setEditingManager(null);
setManagerForm(emptyManagerForm(data.bdLeaderInviteScopePolicy?.regionExpansionConfigurable === true));
setManagerForm(emptyManagerForm(managerCrossRegionConfigurable(data)));
setActiveAction("manager");
};
@ -206,3 +210,10 @@ export function useHostManagersPage() {
userFilter,
};
}
function managerCrossRegionConfigurable(data) {
return (
data?.managerOperationScopePolicy?.regionExpansionConfigurable === true ||
data?.bdLeaderInviteScopePolicy?.regionExpansionConfigurable === true
);
}

View File

@ -22,7 +22,7 @@ const managerPermissionOptions = [
{ key: "canGrantVip", label: "VIP" },
{ key: "canUpdateUserLevel", label: "升级等级" },
{ key: "canAddBdLeader", label: "BD Leader" },
{ key: "canAddBdLeaderInRegion", label: "区域邀请 BD Leader", regionExpansionOnly: true },
{ key: "canManageCrossRegion", label: "跨区经理", crossRegionOnly: true },
{ key: "canAddAdmin", label: "Admin" },
{ key: "canAddSuperadmin", label: "Superadmin" },
{ key: "canBlockUser", label: "Block User" },
@ -205,12 +205,14 @@ function ManagerPermissions({ item }) {
{managerPermissionOptions
.filter(
(permission) =>
!permission.regionExpansionOnly || item?.bdLeaderRegionExpansionConfigurable === true,
!permission.crossRegionOnly ||
item?.managerCrossRegionConfigurable === true ||
item?.bdLeaderRegionExpansionConfigurable === true,
)
.map((permission) => {
const enabled =
permission.key === "canAddBdLeaderInRegion"
? item?.[permission.key] === true
permission.key === "canManageCrossRegion"
? (item?.canManageCrossRegion ?? item?.canAddBdLeaderInRegion) === true
: item?.[permission.key] !== false;
return (
<span
@ -249,14 +251,14 @@ function PermissionSwitchGrid({ disabled, form, onChange }) {
{managerPermissionOptions
.filter(
(permission) =>
!permission.regionExpansionOnly || form?.bdLeaderRegionExpansionConfigurable === true,
!permission.crossRegionOnly || form?.managerCrossRegionConfigurable === true,
)
.map((permission) => (
<label className={styles.permissionSwitch} key={permission.key}>
<span>{permission.label}</span>
<AdminSwitch
checked={
permission.key === "canAddBdLeaderInRegion"
permission.key === "canManageCrossRegion"
? form?.[permission.key] === true
: form?.[permission.key] !== false
}

View File

@ -33,33 +33,33 @@ test("manager status column uses a switch and toggles through the page hook", ()
expect(mocks.toggleManager).toHaveBeenCalledWith(manager, false);
});
test("manager form only shows the region invitation switch when backend policy allows configuration", () => {
test("manager form only shows the cross-region manager switch when backend policy allows configuration", () => {
vi.mocked(useHostManagersPage).mockReturnValue(
pageFixture({
activeAction: "manager",
managerForm: {
...pageFixture().managerForm,
bdLeaderRegionExpansionConfigurable: true,
canAddBdLeaderInRegion: false,
managerCrossRegionConfigurable: true,
canManageCrossRegion: false,
},
}),
);
const { rerender } = render(<HostManagersPage />);
expect(screen.getByRole("switch", { name: "区域邀请 BD Leader" })).not.toBeChecked();
expect(screen.getByRole("switch", { name: "跨区经理" })).not.toBeChecked();
vi.mocked(useHostManagersPage).mockReturnValue(
pageFixture({
activeAction: "manager",
managerForm: {
...pageFixture().managerForm,
bdLeaderRegionExpansionConfigurable: false,
canAddBdLeaderInRegion: false,
managerCrossRegionConfigurable: false,
canManageCrossRegion: false,
},
}),
);
rerender(<HostManagersPage />);
expect(screen.queryByRole("switch", { name: "区域邀请 BD Leader" })).not.toBeInTheDocument();
expect(screen.queryByRole("switch", { name: "跨区经理" })).not.toBeInTheDocument();
});
function pageFixture(patch = {}) {
@ -81,10 +81,10 @@ function pageFixture(patch = {}) {
loadingAction: "",
loadingRegions: false,
managerForm: {
bdLeaderRegionExpansionConfigurable: true,
managerCrossRegionConfigurable: true,
canAddAdmin: true,
canAddBdLeader: true,
canAddBdLeaderInRegion: false,
canManageCrossRegion: false,
canAddSuperadmin: true,
canBlockUser: true,
canGrantAvatarFrame: true,
@ -119,8 +119,8 @@ function managerFixture() {
bdLeaderCount: 3,
canAddAdmin: true,
canAddBdLeader: false,
canAddBdLeaderInRegion: false,
bdLeaderRegionExpansionConfigurable: true,
canManageCrossRegion: false,
managerCrossRegionConfigurable: true,
canAddSuperadmin: true,
canBlockUser: true,
canGrantAvatarFrame: true,

View File

@ -132,7 +132,7 @@ test("manager schema defaults vip grant permission on and preserves explicit fal
expect(disabledResult.success).toBe(true);
if (defaultResult.success) {
expect(defaultResult.data.canGrantVip).toBe(true);
expect(defaultResult.data.canAddBdLeaderInRegion).toBe(false);
expect(defaultResult.data.canManageCrossRegion).toBe(false);
}
if (disabledResult.success) {
expect(disabledResult.data.canGrantVip).toBe(false);

View File

@ -112,7 +112,7 @@ export const createCoinSellerSchema = commandContactSchema.extend({
export const createManagerSchema = z.object({
canAddAdmin: z.boolean().optional().default(true),
canAddBdLeader: z.boolean().optional().default(true),
canAddBdLeaderInRegion: z.boolean().optional().default(false),
canManageCrossRegion: z.boolean().optional().default(false),
canAddSuperadmin: z.boolean().optional().default(true),
canBlockUser: z.boolean().optional().default(true),
canGrantAvatarFrame: z.boolean().optional().default(true),

View File

@ -4677,7 +4677,9 @@ export interface components {
total: number;
};
ApiPageManager: {
bdLeaderInviteScopePolicy: components["schemas"]["ManagerRoleScopePolicy"];
/** @deprecated */
bdLeaderInviteScopePolicy?: components["schemas"]["ManagerRoleScopePolicy"];
managerOperationScopePolicy: components["schemas"]["ManagerRoleScopePolicy"];
items: components["schemas"]["Manager"][];
page: number;
pageSize: number;
@ -5060,6 +5062,8 @@ export interface components {
ManagerRoleScopePolicy: {
/** @enum {string} */
baseScope: "country" | "region" | "global";
/** @enum {string} */
expandedScope: "country" | "region" | "global";
regionExpansionConfigurable: boolean;
};
Manager: {
@ -5067,12 +5071,26 @@ export interface components {
bdLeaderCount?: number;
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
/** @deprecated */
canAddBdLeaderInRegion?: boolean;
/** @enum {string} */
canManageCrossRegion?: boolean;
/**
* @deprecated
* @enum {string}
*/
bdLeaderInviteBaseScope?: "country" | "region" | "global";
/** @enum {string} */
/**
* @deprecated
* @enum {string}
*/
bdLeaderInviteEffectiveScope?: "country" | "region" | "global";
/** @deprecated */
bdLeaderRegionExpansionConfigurable?: boolean;
/** @enum {string} */
managerOperationBaseScope?: "country" | "region" | "global";
/** @enum {string} */
managerOperationEffectiveScope?: "country" | "region" | "global";
managerCrossRegionConfigurable?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;
canGrantAvatarFrame?: boolean;
@ -5244,7 +5262,9 @@ export interface components {
CreateManagerPayload: {
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
/** @deprecated */
canAddBdLeaderInRegion?: boolean;
canManageCrossRegion?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;
canGrantAvatarFrame?: boolean;
@ -5259,7 +5279,9 @@ export interface components {
UpdateManagerPayload: {
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
/** @deprecated */
canAddBdLeaderInRegion?: boolean;
canManageCrossRegion?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;
canGrantAvatarFrame?: boolean;

View File

@ -1,4 +1,5 @@
export interface ApiPage<TItem> {
managerOperationScopePolicy?: ManagerRoleScopePolicy;
bdLeaderInviteScopePolicy?: ManagerRoleScopePolicy;
items: TItem[];
page: number;
@ -8,6 +9,7 @@ export interface ApiPage<TItem> {
export interface ManagerRoleScopePolicy {
baseScope: "country" | "region" | "global";
expandedScope: "country" | "region" | "global";
regionExpansionConfigurable: boolean;
}
@ -762,9 +764,11 @@ export interface ManagerDto {
bdLeaderCount?: number;
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
canManageCrossRegion?: boolean;
managerOperationBaseScope?: "country" | "region" | "global";
managerOperationEffectiveScope?: "country" | "region" | "global";
managerCrossRegionConfigurable?: boolean;
canAddBdLeaderInRegion?: boolean;
bdLeaderInviteBaseScope?: "country" | "region" | "global";
bdLeaderInviteEffectiveScope?: "country" | "region" | "global";
bdLeaderRegionExpansionConfigurable?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;
@ -789,6 +793,7 @@ export interface ManagerDto {
export interface CreateManagerPayload {
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
canManageCrossRegion?: boolean;
canAddBdLeaderInRegion?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;
@ -805,6 +810,7 @@ export interface CreateManagerPayload {
export interface UpdateManagerPayload {
canAddAdmin?: boolean;
canAddBdLeader?: boolean;
canManageCrossRegion?: boolean;
canAddBdLeaderInRegion?: boolean;
canAddSuperadmin?: boolean;
canBlockUser?: boolean;